Reenable use of SelectClauseVisitor for subqueries #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
reviewed
Aug 18, 2023
gliljas
force-pushed
the
selectregression
branch
from
abd1a20
to
4e822cc
Compare
bahusoid
force-pushed
the
selectregression
branch
from
4e822cc
to
4b63457
Compare
bahusoid
previously approved these changes
Aug 18, 2023
bahusoid
approved these changes
Aug 20, 2023
Co-authored-by: Frédéric Delaporte <[email protected]>
fredericDelaporte
approved these changes
Aug 20, 2023
hazzik
approved these changes
Aug 21, 2023
|
A dev package should become available in a few hours, if you wish to check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression caused by #3271.
Select clause rewriting is needed for subqueries, since they may (quite often) use projections with "new".
Relaxing the SelectClauseNominator for subqueries is a potential solution. There shouldn't be a resulting ProjectionExpression, but it works.